For the past couple of years I have taught sentence diagramming to my students. What I have done is teach a lesson or two with each unit (nouns and verbs, adjectives, adverbs, compounds, etc.) I can tell diagramming sentences help them understand the parts of speech better, but I wonder if it would be better to just do one big unit on sent. diagramming at the end of the year rather than spreading the lessons out during the year. Does anyone on this forum teach sentence diagraming? If so, what has worked best for you?